fix: Use correct JSON format for Claude Code stop hooks#109
Closed
fix: Use correct JSON format for Claude Code stop hooks#109
Conversation
The stop hook quality criteria validation was using incorrect JSON response
format that Claude Code doesn't recognize:
- {"ok": true} - Ignored by Claude Code
- {"ok": false, "reason": "..."} - Not recognized as blocking
Changed to the correct format per Claude Code documentation:
- {} - Allow stop (empty JSON)
- {"decision": "block", "reason": "..."} - Block and continue
This fixes the issue where agents could declare quality criteria met without
proper validation blocking incorrect completions.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update skill-template-best-practices rule with correct response format guidance
- Fix hooks_system.md examples to use {} and {"decision": "block", ...}
- Bump version to 0.5.1 and add changelog entry
- Regenerate skill files with updated templates
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{"ok": true/false}to{}and{"decision": "block", "reason": "..."}Test plan
deepwork syncafter merge to regenerate skills🤖 Generated with Claude Code